jQuery UI style protocoll neutral enqueue

  • Resolved ibes

    (@ib4s)


    6 years, 1 month ago

    Hi there,

    you enqueue jQuery UI style like this:
    wp_enqueue_style('jquery-ui-style', 'http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.2/themes/smoothness/jquery-ui.css');

    That creates Mixed Content for all pages that use your plugin and run via HTTPS.

    Could you please chance this to:
    wp_enqueue_style('jquery-ui-style', '//ajax.googleapis.com/ajax/libs/jqueryui/1.8.2/themes/smoothness/jquery-ui.css');

    So it will use whatever protocoll the site is using.
    And yes, that is a valid way to define the protocoll – I first was like “you missed something there” too 🙂

    Would be awesome. As long as this is fixed I guess we will need to hack this in the plugin.
    This is a minor update and should cause no trouble but a big benefit for sites via HTTPS <3

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author JonasBreuer

    (@jonasbreuer)

    6 years, 1 month ago

    Hi ibes,

    I totally agree with you, that this is the right way to enqueue external resources to be compatible with both http and https sites. However, Frontend Checklist currently does not enqueue the jQuery UI CSS.

    I guess you are using the unofficial version with the progressbar, which enqueues the stylesheet in the way you described. If I move this feature into the official version, I will enqueue it in the undefined // way. Thanks for letting me now.

    Cheers,
    Jonas

    Thread Starter ibes

    (@ib4s)

    6 years, 1 month ago

    Oh – is there a way to figure that out?

    Maybe I just updated a plugin that should not have been updated …

    Plugin Author JonasBreuer

    (@jonasbreuer)

    6 years, 1 month ago

    If you are not using the progressbar, you can just overwrite the files of the plugin with the files you can download here on wordpress.org.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘jQuery UI style protocoll neutral enqueue’ is closed to new replies.