Hi @eolsk8 – thanks for the prompt reply!

I did some checking on my end to see if I could come up with anything and from what I found on line 856 of MediaSync.class.php it has:

$attach_id = wp_insert_attachment($attachment, $absolute_path);

According to the WP docs (https://developer.wordpress.org/reference/functions/wp_insert_attachment/) it should just be the file name. I tried hard coding the file name on that line so instead of ‘$absolute_path’ I had ‘2020/02/test-file.gif’ to match the actual file name and upload folder. This resulted in the attachment being added to the wp_posts table and the wp_postmeta and had the correct value for ‘_wp_attached_file’.

However, in wp_postmeta, the ‘_wp_attachment_metadata’ still has the absolute path included as the ‘file’ when it shouldn’t be based on the uploaded attachments I’ve checked that were uploaded directly through WordPress. That would be in relation to line 884:

$attach_data = wp_generate_attachment_metadata($attach_id, $absolute_path);

I just took another look and got it working correctly with my Windows server; although what I’ve changed isn’t going to work as some users might be using a custom upload directory.

The following changes are within “media_sync_update_import_to_database”:

$attach_id = wp_insert_attachment($attachment, $relative_path);

$tmp_relative_path = self::media_sync_url_encode(self::media_sync_get_relative_path($absolute_path));$relative_path = str_replace(“/wp-content/uploads/”, “”, $tmp_relative_path);

Example:
$absolute_path = ‘E:/homepages/1/username/www/wp-content/uploads/2020/02/test-file.gif’
$tmp_relative_path = ‘/wp-content/uploads/2020/02/test-file.gif’
$relative_path = ‘2020/02/test-file.gif’

It seems the “wp_insert_attachment” needs the file name and path relative to the upload directory, in my test if I had ‘/wp-content/uploads/’ included it had an error and using the absolute path caused the entire path to be included.

Additionally, the following line was modified:

$attach_data = wp_generate_attachment_metadata($attach_id, get_attached_file( $attach_id ));

I used the get_attached_file() function in order to get the value from WP which is supposed to use ‘_wp_attached_file’ but it returns ‘E:\homepages\1\username\www/wp-content/uploads/2020/02/test-file.gif’ which is nearly identical to the $absolute_path except the backslashes on the first half of the path until ‘wp-content’. If I supplied $absolute_path to the wp_generate_attachment_metadata function it returned an error generating the metadata. This also can’t be the ‘$absolute_path’ as is provided currently in the plugin as it then saves the “file” in “_wp_attachment_metadata” as the full path.

I’m not sure exactly where the plugin is converting the back slashes but maybe that is the only reason the plugin isn’t saving the post meta correctly as simply using the get_attached_file() instead of $absolute_path saved only the ‘2020/02/test-file.gif’ as the ‘file’ in ‘_wp_attachment_metadata’.

With these changes the file is added to the database correctly and during my test it’s identical to what is inserted if I were to upload the same file in the WP upload.

Programming in PHP isn’t something I deal with much and rarely deal with WP so I’m not familiar with all the functions, so I know the way I’m getting the file path isn’t going to be correct but I was simply trying to get it to work properly on the Windows server to allow you to check on your end.

I’m more than willing to test any revisions to check them on a Windows environment if that helps you.

Sounds good – thank you!

Thanks for the update. I just looked at the plugin file I had modified, does the error your getting occur on the following try/catch:

        try {
            // Generate the metadata for the attachment
            // change line for windows server installation
            $attach_data = wp_generate_attachment_metadata($attach_id, get_attached_file($attach_id));
            // $attach_data = wp_generate_attachment_metadata($attach_id, $absolute_path);
        } catch (Exception $e) {
            return array(
                'errorMessage' => sprintf(__('Error generating attachment metadata (wp_postmeta table) for file: %s.', 'media-sync'), $relative_path),
                'error' => $e->getMessage()
            );
        }

I didn’t get an errors returned from that catch, but if that’s where you see an issue, I’ll try it again. I’ve been using the modified plugin file for several files now and haven’t had any issues and the database tables have the correct format for the urls based on files uploaded directly in WP.

I’m in no rush for this as I have it working for my install currently.

The path returned with get_attached_file($attach_id) is “E:\homepages\1\username\www/wp-content/uploads/2020/02/test-file.gif”.

When I tried the provided: $attach_data = wp_generate_attachment_metadata($attach_id, wp_normalize_path($absolute_path)); It ends up saving the “_wp_attachment_metadata” field with “E:/homepages/1/username/www/wp-content/uploads/2020/02/test-file.gif” when based on all other database entries it should just be “2020/02/test-file.gif”.

I tried the plugin again with the modified line using get_attached_file($attach_id) and it inserts as “2020/02/test-file.gif”.