Directory

⚓ T381741 Toolbar tag flyout: changing tag groups is broken
Page MenuHomePhabricator
Create Task
Maniphest T381741

Toolbar tag flyout: changing tag groups is broken
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by @North8000 at https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Selection_of_tag_sections_in_curation_seems_to_have_stopped_working

Steps to replicate the issue (include links if applicable):

  • Be a patroller
  • Open an unreviewed article in mainspace
  • Toolbar -> Tag
  • Click on Common, Cleanup, Metadata, etc. Anything in the left of the flyout

image.png (605×281 px, 23 KB)

What happens?:

  • Nothing

What should have happened instead?:

  • Should change the tags in the right side of the flyout

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Follow-up I9df39fdcc: Convert missed 'this' to 'el'mediawiki/extensions/PageTriagewmf/1.44.0-wmf.6+1 -1
Follow-up I9df39fdcc: Convert missed 'this' to 'el'mediawiki/extensions/PageTriagewmf/1.44.0-wmf.5+14 -0
Follow-up I9df39fdcc: Convert missed 'this' to 'el'mediawiki/extensions/PageTriagemaster+1 -1
tags: fix menu clicking bugmediawiki/extensions/PageTriagemaster+1 -1
Customize query in gerrit

Related Objects

Mentioned Here
rOPUP110220504b37

Event Timeline

Novem_Linguae created this task.Sun, Dec 8, 11:51 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptSun, Dec 8, 11:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae added a comment.Mon, Dec 9, 12:16 AM

Git bisect says https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1089839 is the root cause. Will post in the patch and see if they want to fix. If they're busy, we can just revert in a couple days.

Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Mon, Dec 9, 12:18 PM
Novem_Linguae added subscribers: Esanders, Krinkle.Mon, Dec 9, 9:49 PM

@Esanders @Krinkle, are you OK with me reverting and backporting https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1089839, or would you prefer to write a precision fix?

gerritbot added a comment.Tue, Dec 10, 1:32 PM

Change #1101862 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] tags: fix menu clicking bug

https://gerrit.wikimedia.org/r/1101862

gerritbot added a project: Patch-For-Review.Tue, Dec 10, 1:32 PM
Esanders added a comment.Tue, Dec 10, 2:02 PM

I'll have a look...

gerritbot added a comment.Tue, Dec 10, 2:10 PM

Change #1101873 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/PageTriage@master] Follow-up I9df39fdcc: Convert missed 'this' to 'el'

https://gerrit.wikimedia.org/r/1101873

gerritbot added a comment.Tue, Dec 10, 2:24 PM

Change #1101862 abandoned by Novem Linguae:

[mediawiki/extensions/PageTriage@master] tags: fix menu clicking bug

Reason:

duplicate of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1101873

https://gerrit.wikimedia.org/r/1101862

gerritbot added a comment.Tue, Dec 10, 2:48 PM

Change #1101873 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Follow-up I9df39fdcc: Convert missed 'this' to 'el'

https://gerrit.wikimedia.org/r/1101873

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Tue, Dec 10, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Dec 10, 3:30 PM
gerritbot added a comment.Wed, Dec 11, 7:55 AM

Change #1102204 had a related patch set uploaded (by Novem Linguae; author: Esanders):

[mediawiki/extensions/PageTriage@wmf/1.44.0-wmf.5] Follow-up I9df39fdcc: Convert missed 'this' to 'el'

https://gerrit.wikimedia.org/r/1102204

gerritbot added a project: Patch-For-Review.Wed, Dec 11, 7:55 AM
gerritbot added a comment.Wed, Dec 11, 7:59 AM

Change #1102205 had a related patch set uploaded (by Novem Linguae; author: Esanders):

[mediawiki/extensions/PageTriage@wmf/1.44.0-wmf.6] Follow-up I9df39fdcc: Convert missed 'this' to 'el'

https://gerrit.wikimedia.org/r/1102205

gerritbot added a comment.Wed, Dec 11, 8:05 AM

Change #1102204 abandoned by Novem Linguae:

[mediawiki/extensions/PageTriage@wmf/1.44.0-wmf.5] Follow-up I9df39fdcc: Convert missed 'this' to 'el'

Reason:

all wikis are currently on wmf.6, so wmf.5 cherry pick not needed.

https://gerrit.wikimedia.org/r/1102204

gerritbot added a comment.Wed, Dec 11, 9:21 PM

Change #1102205 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.44.0-wmf.6] Follow-up I9df39fdcc: Convert missed 'this' to 'el'

https://gerrit.wikimedia.org/r/1102205

Stashbot added a comment.Wed, Dec 11, 9:22 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-11T21:22:02Z] <samtar@deploy2002> Started scap sync-world: Backport for [[gerrit:rOPUP110220504b37|Follow-up I9df39fdcc: Convert missed 'this' to 'el' (T381741)]]

Stashbot added a comment.Wed, Dec 11, 9:25 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-11T21:25:58Z] <samtar@deploy2002> novemlinguae, samtar: Backport for [[gerrit:rOPUP110220504b37|Follow-up I9df39fdcc: Convert missed 'this' to 'el' (T381741)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Wed, Dec 11, 9:30 PM
Stashbot added a comment.Wed, Dec 11, 9:32 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-11T21:32:04Z] <samtar@deploy2002> Finished scap sync-world: Backport for [[gerrit:rOPUP110220504b37|Follow-up I9df39fdcc: Convert missed 'this' to 'el' (T381741)]] (duration: 10m 01s)

Novem_Linguae closed this task as Resolved.Wed, Dec 11, 9:33 PM
Novem_Linguae assigned this task to Esanders.
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.6; 2024-12-03); removed MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Wed, Dec 11, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits