Directory

⚓ T381225 Search index and message cache no longer update on import and undelete
Page MenuHomePhabricator

Search index and message cache no longer update on import and undelete
Closed, ResolvedPublicBUG REPORT

Description

Since we moved the code for updating the message cache and the search index out of DerivedPageDataUpdater, the code is no longer triggered on undeletion and import. Since we are not relying on the PageUpdatedEvent to trigger the listener methods in SearchEventIngress and LanguageEventIngress respectively, they are only run on page edits.

Note that page moves are unaffected, because they do use PageUpdater.

Relevant patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1069667

Possible solutiuons:

  • revert the patch
  • trigger the relevant update code directly from ImportableOldRevisionImporter and UndeletePage
  • trigger the PageUpdatedEvent from inside DerivedPageDataUpdater::doUpdates, instead of doing it in PageUpdater.

Event Timeline

daniel triaged this task as High priority.Sun, Dec 1, 5:26 PM

Change #1099368 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] WIP: Ensure necessary updates are performed on import and undelete

https://gerrit.wikimedia.org/r/1099368

HCoplin-WMF changed the task status from Open to In Progress.Wed, Dec 4, 2:12 PM
HCoplin-WMF assigned this task to daniel.

Change #1099368 merged by jenkins-bot:

[mediawiki/core@master] Ensure necessary updates are performed on import and undelete

https://gerrit.wikimedia.org/r/1099368

Should be fixed now. Not in production yet.