Directory

⚓ T380380 Basic topic selection: Use standard transitions
Page MenuHomePhabricator

Basic topic selection: Use standard transitions
Open, MediumPublic

Description

In T368422, an initial version was implemented to support basic topic selection in order to customize translation suggestions. The "Adjust suggestions view" provides a list of topics for users to select. This is intended to work similar to a Codex dialog component. However, currently it uses a non-standard transition: it appears flying from below the viewport and goes away flying up (not going to the same place where it came from):

Following the Codex dialog component and the current Codex support for transitions, it seems that the standard is for elements to fade in/out.


It is not clear what motivated the use of the current transition. If there is a reason for this to show form below the viewport, we can consider keeping it but adjusting the way the elements disappear by flying back to the bottom too.

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

@Pginer-WMF Do you also expect the "fade" transition when the viewport is small and the dialog is fullscreen?

SBisson triaged this task as Medium priority.
SBisson moved this task from Backlog to In-progress on the LPL Hypothesis board.

Change #1093388 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] SuggestionsFiltersDialog: transition=fade

https://gerrit.wikimedia.org/r/1093388

@Pginer-WMF Do you also expect the "fade" transition when the viewport is small and the dialog is fullscreen?

Yes. I think it makes sense to apply the same approach.

Change #1093388 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SuggestionsFiltersDialog: transition=fade

https://gerrit.wikimedia.org/r/1093388

Change #1104703 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241216

https://gerrit.wikimedia.org/r/1104703

Change #1104703 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20241216

https://gerrit.wikimedia.org/r/1104703