Directory

⚓ T377717 Error thrown when deleting gallery

Maniphest T377717

Error thrown when deleting gallery
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	Esanders
	Oct 21 2024, 1:01 PM

Tags

Referenced Files

None

Subscribers

Description

In VE, select and delete any gallery, e.g. https://en.wikipedia.org/w/index.php?title=Claude_Monet&veaction=edit&section=5

Observe an exception is thrown here:

ve.ce.MWGalleryNode.prototype.onUpdate = function () {
	const mwAttrs = this.model.getAttribute( 'mw' ).attrs;

TypeError: Cannot read properties of null (reading 'getAttribute')

Details

	Subject	Repo	Branch	Lines +/-
	MWGalleryNode: Check node still exists when updating	mediawiki/extensions/VisualEditor	master	+4 -0

Customize query in gerrit

Event Timeline

Esanders created this task.Oct 21 2024, 1:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2024, 1:01 PM

Change #1081970 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] MWGalleryNode: Check node still exists when updating

https://gerrit.wikimedia.org/r/1081970

gerritbot added a project: Patch-For-Review.Oct 21 2024, 1:04 PM

Esanders claimed this task.Oct 21 2024, 1:04 PM

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Oct 28 2024, 4:01 PM

Change #1081970 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWGalleryNode: Check node still exists when updating

https://gerrit.wikimedia.org/r/1081970

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Oct 29 2024, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2024, 11:30 AM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Tue, Dec 17, 4:12 PM

DLynch added a project: Editing QA.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Wed, Dec 18, 3:26 PM

Ryasmeen edited projects, added Verified; removed Editing QA.