⚓ T353388 Enable desktop history HTML on mobile

Enable desktop history HTML on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 13 2023, 10:13 PM

Description

The desktop history page and mobile history page look very similar (in fact the desktop version looks better)
Compare

Screenshot 2023-12-13 at 12.10.27 PM.png (1×1 px, 140 KB)

Screenshot 2023-12-13 at 12.13.26 PM.png (1×1 px, 178 KB)

#TODO:

Enable on beta cluster and provide two URLs.
Fix blockers (see subtasks)
Enable on production pilot wikis
Enable on all production wikis

Sign off steps

Prioritize decommissioning the unused MobileFrontend SpecialHistory page (leaving a redirect)

Details

Subject	Repo	Branch	Lines +/-
Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage	operations/mediawiki-config	master	+0 -5
Use desktop history page HTML everywhere	operations/mediawiki-config	master	+3 -6
Enable desktop history page for all mobile logged in users	operations/mediawiki-config	master	+5 -0
[BC] Enable desktop diff and history pages on mobile	operations/mediawiki-config	master	+15 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T305113 [EPIC] Remove mobile history page
Resolved		Jdlrobson	T353388 Enable desktop history HTML on mobile
Resolved	BUG REPORT	jsn.sherman	T353401 Non-functional input appears on desktop history page when viewed in mobile site
Resolved	BUG REPORT	Jdlrobson	T353403 Talk and article tabs should appear on history page in Minerva
Resolved		Jdlrobson	T353485 Not possible to click history rows when hovering over the date
Resolved		Edtadros	T354218 Long edit summaries spill out of container on history page
Resolved	BUG REPORT	Edtadros	T355369 History page: Username does not wrap.

Event Timeline

Jdlrobson created this task.Dec 13 2023, 10:13 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 13 2023, 10:13 PM

Change 982925 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] [BC] Enable desktop diff and history pages on mobile

https://gerrit.wikimedia.org/r/982925

gerritbot added a project: Patch-For-Review.Dec 13 2023, 10:19 PM

Jdlrobson triaged this task as High priority.Dec 13 2023, 10:22 PM

Jdlrobson moved this task from Backlog to Watchlist on the MobileFrontend (MobileFrontend Special Pages) board.

Jdlrobson merged a task: T350609: Disable the mobile history page and use desktop instead.

Jdlrobson moved this task from Watchlist to History on the MobileFrontend (MobileFrontend Special Pages) board.

Jdlrobson mentioned this in T340158: rename Special:History to Special:MobileHistory?.

Jdlrobson merged a task: T327566: Mobile Page history HTML differ, making scripting hard.

Jdlrobson mentioned this in T312450: Migrate usage of Database::select to SelectQueryBuilder in MobileFrontend.

Jdlrobson mentioned this in T217902: SpecialMobileHistory doesn't respect dir=prev.

Jdlrobson added a subscriber: Dereckson.

Jdlrobson added a subscriber: Ponor.

Jdlrobson mentioned this in T312813: [Regression(??)] Styling issue on non-AMC history and diff pages.Dec 13 2023, 10:40 PM

Change 982925 merged by jenkins-bot:

[operations/mediawiki-config@master] [BC] Enable desktop diff and history pages on mobile

https://gerrit.wikimedia.org/r/982925

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:48:01Z] <jhuneidi@deploy2002> Started scap: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:49:33Z] <jhuneidi@deploy2002> jhuneidi and jdlrobson and cwhite: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:57:43Z] <jhuneidi@deploy2002> Finished scap: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]] (duration: 09m 42s)

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 11:10 PM

Jdlrobson updated the task description. (Show Details)Dec 14 2023, 12:02 AM

Jdlrobson updated the task description. (Show Details)Dec 14 2023, 12:04 AM

Jdlrobson moved this task from Backlog to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Dec 14 2023, 12:23 AM

The only issue I could find is that there's no click dead-zone around the date headers. In the old page if you tap the dates nothing happens. In the new one it always selects the diff above or below. Not the end of the world but might cause some unintended clicks.

Otherwise this is looking good to me!

Jdlrobson closed subtask T353401: Non-functional input appears on desktop history page when viewed in mobile site as Resolved.Dec 14 2023, 5:32 PM

Jdlrobson closed subtask T353403: Talk and article tabs should appear on history page in Minerva as Resolved.Dec 14 2023, 9:21 PM

The only issue I could find is that there's no click dead-zone around the date headers.

Opened T353485. Do you consider this a blocker?

Novem_Linguae unsubscribed.Dec 14 2023, 11:22 PM

In T353388#9408145, @Jdlrobson wrote:

The only issue I could find is that there's no click dead-zone around the date headers.

Opened T353485. Do you consider this a blocker?

Not a blocker :)

Jdlrobson closed subtask T353485: Not possible to click history rows when hovering over the date as Resolved.Dec 20 2023, 7:59 PM

This page looks ready to ship. I plan to deploy this early next year to some pilot wikis with @jsn.sherman 's help. See you all in 2024! Thanks for your help with this initiative!

Jdlrobson mentioned this in T354533: Show page name in history page title in Minevra.Jan 8 2024, 6:18 PM

Change 990152 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop history page for all mobile logged in users

https://gerrit.wikimedia.org/r/990152

gerritbot added a project: Patch-For-Review.Jan 12 2024, 5:18 PM

@Samwalton9-WMF @jsn.sherman we'll get the most feedback from logged in users on English Wikipedia, so I suggest deploying the desktop history page on mobile there on Tuesday. We can aim to expand this to everyone by the end of next week. Let me know if you have any concerns with that plan!

Change 990152 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable desktop history page for all mobile logged in users

https://gerrit.wikimedia.org/r/990152

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:28:25Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:990152|Enable desktop history page for all mobile logged in users (T353388)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:30:04Z] <catrope@deploy2002> jdlrobson and catrope: Backport for [[gerrit:990152|Enable desktop history page for all mobile logged in users (T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2024, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:43:41Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:990152|Enable desktop history page for all mobile logged in users (T353388)]] (duration: 15m 15s)

Jdlrobson updated the task description. (Show Details)Jan 17 2024, 9:50 PM

Jdlrobson updated the task description. (Show Details)

Change 991424 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Use desktop history page HTML everywhere

https://gerrit.wikimedia.org/r/991424

gerritbot added a project: Patch-For-Review.Jan 17 2024, 9:52 PM

Jdlrobson closed subtask T354218: Long edit summaries spill out of container on history page as Resolved.Jan 19 2024, 12:48 AM

Tentative deployment date for everywhere is 29th January. I will circle back then!

Change 991424 merged by jenkins-bot:

[operations/mediawiki-config@master] Use desktop history page HTML everywhere

https://gerrit.wikimedia.org/r/991424

Mentioned in SAL (#wikimedia-operations) [2024-01-29T21:42:14Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:991424|Use desktop history page HTML everywhere (T353388)]], [[gerrit:992931|Begin capturing errors for Wikivoyage]]

Mentioned in SAL (#wikimedia-operations) [2024-01-29T21:43:34Z] <catrope@deploy2002> catrope and jdlrobson: Backport for [[gerrit:991424|Use desktop history page HTML everywhere (T353388)]], [[gerrit:992931|Begin capturing errors for Wikivoyage]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-29T21:54:20Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:991424|Use desktop history page HTML everywhere (T353388)]], [[gerrit:992931|Begin capturing errors for Wikivoyage]] (duration: 12m 05s)

Change 993805 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop English Wikipedia configuration

https://gerrit.wikimedia.org/r/993805

Change 993805 merged by jenkins-bot:

[operations/mediawiki-config@master] Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage

https://gerrit.wikimedia.org/r/993805

Mentioned in SAL (#wikimedia-operations) [2024-01-29T22:02:29Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:993805|Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage (T353388)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-29T22:03:48Z] <catrope@deploy2002> catrope and jdlrobson: Backport for [[gerrit:993805|Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage (T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson added a project: User-notice.Jan 29 2024, 10:30 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2024, 10:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-29T22:31:02Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:993805|Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage (T353388)]] (duration: 28m 33s)

Suggested User-notice text:
"The mobile site now uses the same HTML as the desktop site for history pages. If you hear of any problems relating to mobile history usage please point them to T353388."