⚓ T350181 Enable desktop diff page on mobile site

Enable desktop diff page on mobile site
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Oct 31 2023, 6:31 PM

Description

As documented in T240624#9296077 the mobile diff page can be replaced with the desktop diff page using the following code:

$wgMFUseDesktopDiffPage = [
	"base" => true,
	 "amc" => true
];

The main differences are:

Diff colors are now blue and yellow rather than green and red (this fixes concerns raised in T90948)
At desktop resolutions diffs revert to the desktop version. e.g. visual mode
The page actions shows instead of the title within the diff
The diff no longer shows information on bytes added/removed.

TODO

Make the configuration change on beta cluster
Fix blockers (T353407 T353404)
Get product owner/designer to sign off the differences.
Enable on pilot wikis
Enable for English Wikipedia anonymous users.
Deploy everywhere

sign off steps

Create task for decommissioning the MobileDiff page. T358293

Details

Subject	Repo	Branch	Lines +/-
Enable desktop diff for anonymous users on enwiki	operations/mediawiki-config	master	+2 -1
Enable desktop diff HTML on mobile pages for all logged in users	operations/mediawiki-config	master	+10 -0
Add wg prefix	operations/mediawiki-config	master	+2 -2
[BC] Enable desktop diff and history pages on mobile	operations/mediawiki-config	master	+15 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		• tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		None	T350181 Enable desktop diff page on mobile site
Resolved	BUG REPORT	SBisson	T353404 Wikistory showing on mobile diff page
Resolved		Jdlrobson	T353407 Diff footer is overlaying the text when visual diff is clicked
Resolved	BUG REPORT	Jdlrobson	T353478 Diff tables collapse incorrectly on tablet breakpoint
Resolved		JSengupta-WMF	T353479 Diff legend does not display in mobile HTML
Open	BUG REPORT	None	T361176 visualdiff legend colors are mismatched
Open	BUG REPORT	None	T353062 Core diff on mobile buggy codex thank button
Resolved		Jdlrobson	T357079 Wrong digit on bnwiki mobile diff

Event Timeline

Jdlrobson created this task.Oct 31 2023, 6:31 PM

Volker_E awarded a token.Nov 1 2023, 3:15 AM

Jdlrobson moved this task from Backlog to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Nov 3 2023, 12:06 AM

Jdlrobson triaged this task as High priority.Dec 13 2023, 9:57 PM

Jdlrobson moved this task from Backlog to Diffs on the MobileFrontend (MobileFrontend Special Pages) board.

Jdlrobson mentioned this in T290440: imported> on diff page should not link to contributions on Mobile view.

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptDec 13 2023, 9:58 PM

Change 982925 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] [BC] Enable desktop diff and history pages on mobile

https://gerrit.wikimedia.org/r/982925

gerritbot added a project: Patch-For-Review.Dec 13 2023, 10:19 PM

Change 982925 merged by jenkins-bot:

[operations/mediawiki-config@master] [BC] Enable desktop diff and history pages on mobile

https://gerrit.wikimedia.org/r/982925

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:48:01Z] <jhuneidi@deploy2002> Started scap: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:49:33Z] <jhuneidi@deploy2002> jhuneidi and jdlrobson and cwhite: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:57:43Z] <jhuneidi@deploy2002> Finished scap: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]] (duration: 09m 42s)

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 11:10 PM

Change 982936 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Add wg prefix

https://gerrit.wikimedia.org/r/982936

gerritbot added a project: Patch-For-Review.Dec 13 2023, 11:30 PM

Change 982936 merged by jenkins-bot:

[operations/mediawiki-config@master] Add wg prefix

https://gerrit.wikimedia.org/r/982936

Jdlrobson added a subtask: T353404: Wikistory showing on mobile diff page.Dec 14 2023, 12:09 AM

Jdlrobson updated the task description. (Show Details)

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 12:10 AM

Jdlrobson updated the task description. (Show Details)Dec 14 2023, 12:22 AM

Nardog unsubscribed.Dec 14 2023, 12:28 AM

This is looking really great, but I do think we need to decide what to do with added/removed colours. Green and red have some basis in being 'positive' (added) and 'negative' (removed), whereas yellow and blue have no meaning. A new user would have no idea which was which. The CommTech team made some design proposals on how to address this, such as having a legend indicating which colour is which. What do you think?

In T350181#9406322, @Samwalton9-WMF wrote:

This is looking really great, but I do think we need to decide what to do with added/removed colours. Green and red have some basis in being 'positive' (added) and 'negative' (removed), whereas yellow and blue have no meaning. A new user would have no idea which was which. The CommTech team made some design proposals on how to address this, such as having a legend indicating which colour is which. What do you think?

I've just read that page properly and it turns out this legend does exist in production when you turn inline view on - could we add it to the mobile view too?

Jdlrobson added a subtask: T353478: Diff tables collapse incorrectly on tablet breakpoint.Dec 14 2023, 7:24 PM

@Samwalton9-WMF that is exactly what we are talking about in T353479

Jdlrobson closed subtask T353478: Diff tables collapse incorrectly on tablet breakpoint as Resolved.Dec 20 2023, 7:58 PM

LordProfo unsubscribed.Dec 20 2023, 8:01 PM

PWaigi-WMF closed subtask T353404: Wikistory showing on mobile diff page as Resolved.Dec 21 2023, 9:42 AM

Jdlrobson added a subtask: T353062: Core diff on mobile buggy codex thank button.Jan 5 2024, 9:47 PM

Jdlrobson updated the task description. (Show Details)

ovasileva subscribed.Jan 8 2024, 9:32 AM

Jdlrobson mentioned this in T354840: mobilediff coloring does not match the header definitions.Jan 11 2024, 8:42 PM

DMacks subscribed.Jan 12 2024, 2:18 PM

Jdlrobson changed the status of subtask T353062: Core diff on mobile buggy codex thank button from Open to Stalled.Jan 12 2024, 5:09 PM

Jdlrobson mentioned this in T353062: Core diff on mobile buggy codex thank button.

Jdlrobson closed subtask T353479: Diff legend does not display in mobile HTML as Resolved.Jan 30 2024, 7:17 PM

Change 994224 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop diff HTML on mobile pages for all logged in users

https://gerrit.wikimedia.org/r/994224

gerritbot added a project: Patch-For-Review.Jan 30 2024, 7:19 PM

Just BTW, but it is weird that visual is red-green and wikitext (inline) diff is yellow-blue. Shouldn't they both be red-green?

Get product owner/designer to sign off the differences.

I'm happy with this change - it's clearly a net positive.

Change 994224 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable desktop diff HTML on mobile pages for all logged in users

https://gerrit.wikimedia.org/r/994224

Mentioned in SAL (#wikimedia-operations) [2024-02-05T21:31:28Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:994224|Enable desktop diff HTML on mobile pages for all logged in users (T350181)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-05T21:32:49Z] <cjming@deploy2002> jdlrobson and cjming: Backport for [[gerrit:994224|Enable desktop diff HTML on mobile pages for all logged in users (T350181)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-05T21:40:57Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:994224|Enable desktop diff HTML on mobile pages for all logged in users (T350181)]] (duration: 09m 29s)

Jdlrobson updated the task description. (Show Details)Feb 5 2024, 9:42 PM

Change 997585 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop diff for anonymous users as well

https://gerrit.wikimedia.org/r/997585

@Nux can you please raise a bug for the VisualEditor-VisualDiffs extension (it's better for a bug report to come from someone other than me!)? This seems unrelated since this inconsistency happens on desktop too)

Screenshot 2024-01-30 at 5.45.08 PM.png (754×1 px, 183 KB)

Jdlrobson mentioned this in T356717: Make it possible to show page content below diffs on mobile.Feb 5 2024, 11:24 PM

Jdlrobson updated the task description. (Show Details)Feb 5 2024, 11:48 PM

Jdlrobson closed subtask T353407: Diff footer is overlaying the text when visual diff is clicked as Resolved.Feb 8 2024, 12:44 AM

I was hoping I wasn't too late to make all of them red-green (so changing mobile/wikitext, not VE)... I think I agree with Sam here:

In T350181#9406322, @Samwalton9-WMF wrote:

This is looking really great, but I do think we need to decide what to do with added/removed colours. Green and red have some basis in being 'positive' (added) and 'negative' (removed), whereas yellow and blue have no meaning. A new user would have no idea which was which. The CommTech team made some design proposals on how to address this, such as having a legend indicating which colour is which. What do you think?

The legend is cool and helpful either way. I was just hoping maybe we could go back to red-green, which is more obvious (at least in Europe and its descendants). Well maybe not go back... It was yellow-green before.

But I guess it's too late to suggest that. No biggie. I already have a custom style for diffs for myself (so not pushing) :)

Sorry, I forgot I have a much smaller request. Could you flip the legend in HTML? I think "removed" belongs on the left side, and this is where inline diff puts "removed".

I have CSS for that, but I think it would be better to do it in the structure.

.mw-diff-inline-legend {
	display:flex;
	flex-direction: row-reverse;
}

Diff colors: see T90948: Identify the best diff style (mobile or desktop) and use it on both mobile and desktop, which has related links and rationale for why blue and yellow exist. The short answer is red-green color blindness, especially in the context of inline diffs. That task has already been linked here and is the correct place to discuss further if at all.

FWIW, there are other contexts that use yellow and blue for "caution" and "everything's fine", respectively — my wireless router, for example. [grin]

Would it be possible to make the colors a user preference? If we provided good enough choices, that could take care of basically every type of color blindness, as well as plain ol' personal preference.

In T350181#9527187, @Izno wrote:

Diff colors: see T90948: Identify the best diff style (mobile or desktop) and use it on both mobile and desktop, which has related links and rationale for why blue and yellow exist. The short answer is red-green color blindness, especially in the context of inline diffs. That task has already been linked here and is the correct place to discuss further if at all.

Thanks, I added my comment there: T90948#9527537

And sorry, I didn't know it is considered such a big decision, but I guess it makes sense, as diffs are important part of patrolling changes. I should have probably looked around a bit more.

Jdlrobson mentioned this in T357150: Suggestion: Flip legend keys for inline diff.Feb 9 2024, 4:23 PM

@Dcljr It's definitely possible. The colors are relatively easy to configure using gadget/user CSS. I see there is already the existing gadget "Display diffs with the old yellow-and-green colors and design" (https://en.wikipedia.org/wiki/MediaWiki:Gadget-OldDiff.css). If you want feel to free to propose a ticket to make these configurable in preferences (although I'm not sure if that will be prioritized)

@Nux for the flipping I created a new ticket: T357150

Jdlrobson added a subtask: T357079: Wrong digit on bnwiki mobile diff.Feb 9 2024, 4:39 PM

The coloring looks off if you click on Special:MobileDiff. e.g. this: https://fa.wikipedia.org/wiki/Special:MobileDiff/38611902

Can we just drop the code for MobileDiff and make it redirect to the general diff now? That'll clean up a lot.

Can we just drop the code for MobileDiff and make it redirect to the general diff now? That'll clean up a lot.

@Ladsgroup this is what the EPIC ticket in T117279 is about and what I've been working towards over the last year or so (and we're almost there) :-)
MobileDiff is dropped on logged in users in production already. After I've fixed a few bugs we've identified in the last week we'll drop it from mobile (either next week or week after) and then I'll open a task to decommission (delete) the MobileDiff code and leave a redirect by the end of February.

Noted. Thanks!

Jdlrobson closed subtask T357079: Wrong digit on bnwiki mobile diff as Resolved.Feb 12 2024, 10:14 PM

Change 997585 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable desktop diff for anonymous users on enwiki

https://gerrit.wikimedia.org/r/997585

Mentioned in SAL (#wikimedia-operations) [2024-02-20T21:22:23Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:997585|Enable desktop diff for anonymous users on enwiki (T350181)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-20T21:23:52Z] <cjming@deploy2002> jdlrobson and cjming: Backport for [[gerrit:997585|Enable desktop diff for anonymous users on enwiki (T350181)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2024, 9:31 PM

Jdlrobson updated the task description. (Show Details)Feb 20 2024, 9:35 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-20T21:35:42Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:997585|Enable desktop diff for anonymous users on enwiki (T350181)]] (duration: 13m 19s)

Jdlrobson updated the task description. (Show Details)Feb 21 2024, 6:51 PM

Jdlrobson closed this task as Resolved.Feb 22 2024, 9:41 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson changed the status of subtask T353062: Core diff on mobile buggy codex thank button from Stalled to Open.Feb 23 2024, 2:10 AM

	F41829168: grafik.png
	Feb 9 2024, 4:42 PM

	F41818739: obraz.png
	Feb 8 2024, 8:28 PM

	F41732544: obraz.png
	Jan 30 2024, 10:37 PM

	F41732541: obraz.png
	Jan 30 2024, 10:37 PM

Directory

Enable desktop diff page on mobile siteClosed, ResolvedPublicActions

Description

TODO

sign off steps

Details

Related ObjectsSearch...

Event Timeline

Enable desktop diff page on mobile site
Closed, ResolvedPublic
Actions

Related Objects
Search...