⚓ T346845 Delete and Message participant button alignment and spacing issue

Delete and Message participant button alignment and spacing issue
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	vaughnwalters
	Sep 19 2023, 10:09 PM

Description

Follow up from T326619#9177744

In the participants tab, the Delete and Message participants buttons have a slight vertical alignment issue. When inspecting it you can see where it is off:

The Delete button and the Message Participants button should not have any space between the buttons.

comp	build

from @gonyeahialam in T326619#9177744:

Yes, the buttons are together, the component is called a ButtonGroupWidget (destructive and progressive ButtonWidget)

Acceptance criteria:

The buttons should be aligned vertically
The buttons should have no space between them horizontally

Details

	Subject	Repo	Branch	Lines +/-
	Fix button spacing in the participants tab	mediawiki/extensions/CampaignEvents	master	+21 -18

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T346968 [EPIC] Feature Improvements to Email Participants
		Resolved		Daimona	T346845 Delete and Message participant button alignment and spacing issue

Event Timeline

vaughnwalters created this task.Sep 19 2023, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2023, 10:09 PM

vaughnwalters attached a referenced file: F37731025: Screenshot 2023-09-18 at 9.03.35 PM.png. (Show Details)Sep 19 2023, 10:09 PM

vaughnwalters attached a referenced file: F37731023: Screenshot 2023-09-18 at 8.56.59 PM.png. (Show Details)

vaughnwalters attached a referenced file: F37731027: Screenshot 2023-09-18 at 9.05.09 PM.png. (Show Details)

vaughnwalters updated the task description. (Show Details)Sep 19 2023, 10:16 PM

vaughnwalters updated the task description. (Show Details)

vaughnwalters mentioned this in T326619: Implement participant selection logic and interface.Sep 19 2023, 10:29 PM

vaughnwalters added a parent task: T346968: [EPIC] Feature Improvements to Email Participants.Sep 20 2023, 6:43 PM

gonyeahialam mentioned this in T346968: [EPIC] Feature Improvements to Email Participants.Oct 26 2023, 12:53 PM

I have discussed this with @gonyeahialam, and he has highlighted that this is his priority for us to fix first because it would improve the user experience and it would be easier to implement than some of the other UX issues to fix, as outlined in T346968. For this reason, we can look into working on this soon.

Daimona claimed this task.Oct 30 2023, 3:38 PM

Daimona edited projects, added Campaigns-Product-Team (Campaign-Tools-Current-Sprint); removed Campaigns-Product-Team.

Daimona moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Oct 30 2023, 3:41 PM

Change 969808 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix button spacing in the participants tab

https://gerrit.wikimedia.org/r/969808

gerritbot added a project: Patch-For-Review.Oct 30 2023, 4:00 PM

Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Oct 30 2023, 4:01 PM

Change 969808 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix button spacing in the participants tab

https://gerrit.wikimedia.org/r/969808

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2023, 10:30 AM

Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Oct 31 2023, 1:08 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Oct 31 2023, 2:02 PM

✅ The buttons should be aligned vertically
✅ The buttons should have no space between them horizontally

gonyeahialam moved this task from Design sign-off 🖌️ to Product sign-off 🖌️ on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Nov 2 2023, 10:34 AM

ifried closed this task as Resolved.Nov 9 2023, 7:36 PM

ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.

Directory

Delete and Message participant button alignment and spacing issueClosed, ResolvedPublicActions