Directory

⚓ T346615 🚅️ Optimize validator instantiation code
Page MenuHomePhabricator
Create Task
Maniphest T346615

🚅️ Optimize validator instantiation code
Closed, ResolvedPublic
Actions

Description

The request validation code currently instantiates more validators than it needs in most cases. We should lazily instantiate the required validators for each request instead of instantiating all of them right away.

Details

SubjectRepoBranchLines +/-
REST: Use service container for validator instantiationmediawiki/extensions/Wikibasemaster+493 -534
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Sep 18 2023, 9:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2023, 9:58 AM
Jakob_WMDE claimed this task.Sep 19 2023, 8:33 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 3) board.
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 4); removed Wikibase Product Platform Team WPP (Sprint 3).Sep 19 2023, 9:25 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 4) board.
gerritbot added a comment.Sep 19 2023, 3:21 PM

Change 958954 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use service container for validator instantiation

https://gerrit.wikimedia.org/r/958954

gerritbot added a project: Patch-For-Review.Sep 19 2023, 3:21 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 4) board.Sep 20 2023, 8:38 AM
gerritbot added a comment.Sep 20 2023, 1:16 PM

Change 958954 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use service container for validator instantiation

https://gerrit.wikimedia.org/r/958954

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 4) board.Sep 20 2023, 1:17 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 20 2023, 1:31 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Sep 25 2023, 8:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits