| Lucas_Werkmeister_WMDE | |
| Aug 1 2023, 8:37 AM2023-08-01 08:37:45 (UTC+0) |
| F37158276: image.png | |
| Aug 1 2023, 8:37 AM2023-08-01 08:37:46 (UTC+0) |
Test Wikidata with useskin=vector currently looks like this for me:
Only broken visuals, but on every page load for legacy Vector users (which is still the default on several large wikis).
Locally, the error vanishes if I revert 38c26f66d0 (T335273: Echo notification count disappears on load in mobile skin).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | dancy | T340248 1.41.0-wmf.20 deployment blockers | ||
| Resolved | PRODUCTION ERROR | Urbanecm_WMF | T343192 Repeated notification icons on 1.41.0-wmf.20 when using legacy Vector |
Thanks for the report!
Also happens in monobook. I don't know why this happens – if I create a testing RL module that loads the less file unconditionally and load it via console on vector/monobook, it works, so it sounds like the default is silently ignored. This might be caused by https://www.mediawiki.org/wiki/Manual:$wgResourceModuleSkinStyles not having a + in front of ext.echo.styles.badge. I can fix this by the following patch in Monobook:
urbanecm@wmf3345 MonoBook % git diff diff --git a/skin.json b/skin.json index 3b552ae..638c565 100644 --- a/skin.json +++ b/skin.json @@ -107,7 +107,7 @@ }, "ResourceModuleSkinStyles": { "monobook": { - "ext.echo.styles.badge": "resources/skinStyles/ext.echo.styles.badge.less", + "+ext.echo.styles.badge": "resources/skinStyles/ext.echo.styles.badge.less", "+mediawiki.action.view.filepage": "resources/skinStyles/mediawiki.action.view.filepage.less", "+mediawiki.action.view.redirectPage": "resources/skinStyles/mediawiki.action.view.redirectPage.css", "+mediawiki.notification": "resources/skinStyles/mediawiki.notification.less", urbanecm@wmf3345 MonoBook %
but the same thing doesn't seem to work in Vector. Not sure why.
Anyway, this is train blocking and the root causing patch is identified. Reverting and backporting.
Change 943602 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/Echo@master] Revert "Fixes: Echo notification count disappears on load in mobile skin"
Change 943602 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Revert "Fixes: Echo notification count disappears on load in mobile skin"
Change 943605 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/Echo@wmf/1.41.0-wmf.20] Revert "Fixes: Echo notification count disappears on load in mobile skin"
Change 943605 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.41.0-wmf.20] Revert "Fixes: Echo notification count disappears on load in mobile skin"
Mentioned in SAL (#wikimedia-operations) [2023-08-01T09:35:49Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:943605|Revert "Fixes: Echo notification count disappears on load in mobile skin" (T335273 T343192)]]
Mentioned in SAL (#wikimedia-operations) [2023-08-01T09:37:26Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:943605|Revert "Fixes: Echo notification count disappears on load in mobile skin" (T335273 T343192)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)
Mentioned in SAL (#wikimedia-operations) [2023-08-01T09:47:24Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:943605|Revert "Fixes: Echo notification count disappears on load in mobile skin" (T335273 T343192)]] (duration: 11m 35s)
