ApiStashEditTest fails if temporary user accounts are enabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jul 16 2023, 2:04 PM

Description

To reproduce:

Add $wgAutoCreateTempUser['enabled'] = true; to your LocalSettings.php
Run ApiStashEditTest::testCheckCacheOldNoEditsAnon

it fails with:

Attempt to read property "output" on bool
 /var/www/html/w/tests/phpunit/includes/api/ApiStashEditTest.php:379
 /var/www/html/w/tests/phpunit/includes/api/ApiStashEditTest.php:398
 /var/www/html/w/tests/phpunit/includes/api/ApiTestCase.php:277
 /var/www/html/w/tests/phpunit/MediaWikiIntegrationTestCase.php:527

It looks like there's a cache key mismatch, but since the test is messing with the cache key in doStashOld, maybe it should just be fixed not to be hacky.

Details

	Subject	Repo	Branch	Lines +/-
	Make ApiStashEditTest work if temp users are enabled	mediawiki/core	master	+5 -14

Customize query in gerrit

Event Timeline

Daimona created this task.Jul 16 2023, 2:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2023, 2:04 PM

And other tests in ApiStashEditTest fail in other ways when testing anons. I'll override the config for those, although eventually I assume we'll want to test both scenarios.

Change 938446 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Make ApiStashEditTest work if temp users are enabled

https://gerrit.wikimedia.org/r/938446

gerritbot added a project: Patch-For-Review.Jul 16 2023, 2:23 PM

Change 938446 merged by jenkins-bot:

[mediawiki/core@master] Make ApiStashEditTest work if temp users are enabled

https://gerrit.wikimedia.org/r/938446

Daimona closed this task as Resolved.Jul 17 2023, 1:50 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 17 2023, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2023, 2:10 PM