Change 935735 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Do not show duplicate message when user in editing the text

https://gerrit.wikimedia.org/r/935735

Change 935735 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Do not show duplicate message when user in editing the text

https://gerrit.wikimedia.org/r/935735

@hueitan Please see the results below and let me know how you want to proceed or create any tasks. Thanks!

Browserstack: iOS (iPhone 14- Safari) and Android (Galaxy S23- Chrome)
Test link: https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#story

Fixing duplicate issues relevant edit message- For English when you edit, it says "Thanks for keeping stories accurate. For Spanish or emojis when you edit from a duplicate, you get a "Please avoid removing too much text'

Results	English	Spanish	Emoji
Duplicate
Edit

Potential Questionable Issues:

Edit before clicking on Done- In Edit, you can have a duplicate message with no warning unless you click on Done. Would it be possible be better to have the warning in real-time, before you click on Done so you don't have to go back and edit it again?

Select story text from Wikipedia- If you edit it and delete the whole text, how come you can't have that option again show up unless you select Done and then go back into the edit again?

Warning Message color- Do you think having the duplicate warning icon be a different color so the user can recognize it better since most of the colors in Minerva are grey and white?

@GMikesell-WMF thanks for the testing, regards duplication text, this is the initial ticket T329898: Treating repeated text on wikistories

regards the user experience, i think @SGautam_WMF should take a look here, let us know what do you think.

Thanks @GMikesell-WMF for the feedback. I am looking into it and will get back soon.

In T340662#9046267, @GMikesell-WMF wrote:

@hueitan Please see the results below and let me know how you want to proceed or create any tasks. Thanks!

Browserstack: iOS (iPhone 14- Safari) and Android (Galaxy S23- Chrome)
Test link: https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#story

Fixing duplicate issues relevant edit message- For English when you edit, it says "Thanks for keeping stories accurate. For Spanish or emojis when you edit from a duplicate, you get a "Please avoid removing too much text'

Results	English	Spanish	Emoji
Duplicate
Edit

Could you provide more context on how you inserted Spanish text? Did you replace English text in Spanish, reducing the original text length in the process? We display different editing messages based on the percentage of changes made to the original text (the text selected from an article):

• No change: "Thanks for keeping stories accurate".
• Changes less than 70%: "As you edit, please maintain the original meaning of the story text".
• Changes more than 70%: "Please avoid removing too much text".

More info here - T329898, T319198

Potential Questionable Issues:

Edit before clicking on Done- In Edit, you can have a duplicate message with no warning unless you click on Done. Would it be possible be better to have the warning in real-time, before you click on Done so you don't have to go back and edit it again?

Your observation seems to concern a situation where a user creates duplicate text while editing. Currently, we don't display a duplicate warning in this scenario due to other warning messages taking precedence. We should consider this further and possibly create a separate task for it.

Select story text from Wikipedia- If you edit it and delete the whole text, how come you can't have that option again show up unless you select Done and then go back into the edit again?

Thank you for pointing this out. We will create a separate task to address this issue.

Warning Message color- Do you think having the duplicate warning icon be a different color so the user can recognize it better since most of the colors in Minerva are grey and white?

I will look into the possibility and implications of changing the warning message color. Thanks for bringing this up.

@SGautam_WMF

Could you provide more context on how you inserted Spanish text? Did you replace English text in Spanish, reducing the original text length in the process? We display different editing messages based on the percentage of changes made to the original text (the text selected from an article):

No change: "Thanks for keeping stories accurate".
Changes less than 70%: "As you edit, please maintain the original meaning of the story text".
Changes more than 70%: "Please avoid removing too much text".

Thanks for the information, that's very helpful! I will test it again once Beta is back up and running again.

Your observation seems to concern a situation where a user creates duplicate text while editing. Currently, we don't display a duplicate warning in this scenario due to other warning messages taking precedence. We should consider this further and possibly create a separate task for it.

Sounds good. Would you like me to create a separate task for it or have the team discuss about it more?

Thank you for pointing this out. We will create a separate task to address this issue.

Perfect, thanks!

I will look into the possibility and implications of changing the warning message color. Thanks for bringing this up.

Sounds good, please keep me posted!

Thank you for pointing this out. We will create a separate task to address this issue.

Perfect, thanks!

T343553

With T343553 being created and Relevant edit messages as seen below, this can be moved to Sign-off. Thanks again!

Status: ✅ PASS
Environment: Beta
OS: macOS Ventura, iOS
Browser: Chrome 116, Firefox 116, Safari 16.6
Device: MBP
Emulated Device:BrowserStack, Dev Tool
Test Link:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:StoryBuilder/Story:Dog_Test?frameid=0#story

Could you provide more context on how you inserted Spanish text? Did you replace English text in Spanish, reducing the original text length in the process? We display different editing messages based on the percentage of changes made to the original text (the text selected from an article):

No change: "Thanks for keeping stories accurate".
Changes less than 70%: "As you edit, please maintain the original meaning of the story text".
Changes more than 70%: "Please avoid removing too much text".

With the info mentioned, that makes sense now. It doesn't matter if it's in another language or emoticons.

No Change	< 70%	> 70%