Directory

⚓ T340115 [clickwrap] Clickwrap Agreement prompt for organisers
Page MenuHomePhabricator

[clickwrap] Clickwrap Agreement prompt for organisers
Closed, ResolvedPublic

Description

Acceptance criteria

Given I am an organizer
When I go to Special:EnableEventRegistration
Then the agreement text for viewing PII should be shown
And a checkbox should be shown to accept the agreement

Given I am an organizer
When I go to Special:EditEventRegistration
And I have not accepted the PII agreement
Then the agreement text for viewing PII should be shown
And a checkbox should be shown to accept the agreement

Given I am an organizer
When I go to Special:EditEventRegistration
And I have accepted the PII agreement
Then the agreement text for viewing PII should be shown
And a checkbox should be shown that is disabled.

Given I am an organizer
When I go to Special:EventDetails
And I am viewing the Response Statistics tab
And I have not accepted the PII agreement
Then the agreement text for viewing PII should be shown
And a checkbox should be shown to accept the agreement
And a button to submit the acceptance should be shown.

Given I am an organizer
When I go to Special:EventDetails
And I am viewing the Response Statistics tab
And I have accepted the PII agreement
Then I should see the standard content for the response statistics tab

Given the environment is a wikimedia foundation wiki
the PII agreement text should read: "I agree to handle the participant information collected during event registration with care and in accordance with Wikimedia Foundation's https://foundation.wikimedia.org/wiki/Special:MyLanguage/Policy:Terms_of_Use Terms of use."

Given the environment is not a wikimedia foundation wiki
the PII agreement text should read: "I agree to handle the participant information collected during event registration with care."

All other text should be as per the below designs.

Design

Clickwrap appears when the event creator is enabling registration. Design specsClickwrap appears here for additional organizers or if the event creator didn't accept when enabling registration. Design specs
Screenshot 2023-07-27 at 12.33.24.png (1×1 px, 212 KB)
Screen Recording 2023-07-27 at 12.31.52.gif (600×960 px, 46 KB)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gonyeahialam changed the task status from Open to In Progress.Jul 12 2023, 4:50 PM
gonyeahialam added a project: Campaigns-Design.

Design update:
(This task is dependent on the conversation here T334761)

Clickwrap appears when the event creator is enabling registrationClickwrap appears here for additional organizers or if the event creator didn't accept when enabling registration
Screenshot 2023-07-12 at 17.02.42.png (1×1 px, 237 KB)
Screen Recording 2023-07-12 at 17.03.08.gif (595×960 px, 72 KB)

Latest design/copy

Clickwrap appears when the event creator is enabling registrationClickwrap appears here for additional organizers or if the event creator didn't accept when enabling registration
Screenshot 2023-07-19 at 14.12.13.png (956×1 px, 167 KB)
Screenshot 2023-07-19 at 14.09.12.png (1×2 px, 168 KB)

Latest design/copy

Clickwrap appears when the event creator is enabling registrationClickwrap appears here for additional organizers or if the event creator didn't accept when enabling registration
Screenshot 2023-07-27 at 12.33.24.png (1×1 px, 212 KB)
Screen Recording 2023-07-27 at 12.31.52.gif (600×960 px, 46 KB)

@gonyeahialam One note about the design for the checkbox in the registration form. In the prototype, we have the label on top of the checkbox, and the help text next to the checkbox. Also, the label is more like some introductory text, and the help text is being used as a label. This is not exactly how this will work in practice. Instead, it'll be like this:

image.png (118×796 px, 12 KB)

would it be possible to adapt the prototype so that it works this way?

@gonyeahialam One note about the design for the checkbox in the registration form. In the prototype, we have the label on top of the checkbox, and the help text next to the checkbox. Also, the label is more like some introductory text, and the help text is being used as a label. This is not exactly how this will work in practice. Instead, it'll be like this:

image.png (118×796 px, 12 KB)

would it be possible to adapt the prototype so that it works this way?

In the design, the text beside the checkbox is the label and the text on top is a normal/introductory text.

In the design, the text beside the checkbox is the label and the text on top is a normal/introductory text.

Thanks for clarifying. Then I guess the issue would be: we don't have a way to specify introductory text for a field. We can add a separate form section with some text, but that text would not be in any way related to the checkbox and its label.

@gonyeahialam I just realized we have another problem. The only way for additional organizers to accept the clickwrap is from the response statistics tab. And same for the event creator, if they do not accept when enabling registration. However, the tab is not displayed until the event has ended, meaning additional organizers (and potentially the creator) will not be able to see individual responses in the participants table. I think two potential ways forward might be:

  • Display the response statistics tab from the start, not just when the event has ended. And add some placeholder text that would be shown before the event has ended to organizers who have already accepted the clickwrap
  • Put this checkbox in an entirely different place that is always available

I think the first option is in line with the idea of always showing the tab that we already discussed in other places. Also, it would be a smaller change to implement, especially if @MHorsey-WMF has already worked on the current implementation. WDYT?

@gonyeahialam I just realized we have another problem. The only way for additional organizers to accept the clickwrap is from the response statistics tab. And same for the event creator, if they do not accept when enabling registration. However, the tab is not displayed until the event has ended, meaning additional organizers (and potentially the creator) will not be able to see individual responses in the participants table. I think two potential ways forward might be:

  • Display the response statistics tab from the start, not just when the event has ended. And add some placeholder text that would be shown before the event has ended to organizers who have already accepted the clickwrap
  • Put this checkbox in an entirely different place that is always available

I think the first option is in line with the idea of always showing the tab that we already discussed in other places. Also, it would be a smaller change to implement, especially if @MHorsey-WMF has already worked on the current implementation. WDYT?

The individual responses on the participants table are non-PII and are therefore always available to all organizers whether they accept clickwrap or not as confirmed by Ilana's last update on this from legal:

UPDATE: Legal has confirmed that organizers do not need to accept the clickwrap agreement to view non-PII data. I will share as a comment in this thread their full response for anyone who is curious.

Has the above decision changed?

The individual responses on the participants table are non-PII and are therefore always available to all organizers whether they accept clickwrap or not as confirmed by Ilana's last update on this from legal:

Oh, thank you, looks like I missed that. There has been some confusion about this in the past, see also e.g. T334761#9083716. But if the non-PII data in the table can be seen by any organizer (regardless of whether they accepted the CW), then I think we're fine!

Okay @Daimona, I will add Ilana's legal update to the task for documentation purposes

Change 963278 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add new section

https://gerrit.wikimedia.org/r/963278

@gonyeahialam The AC says that this will appear when enabling registration, but does not specify if it should appear when EDITING registration. If the organiser does not accept the agreement initially, should it show on the edit form for them?

@gonyeahialam The AC says that this will appear when enabling registration, but does not specify if it should appear when EDITING registration. If the organiser does not accept the agreement initially, should it show on the edit form for them?

If the organiser doesn't accept it initially it should show on the edit form

@ifried The message here is Wikimedia specific "In accordance with the Wikimedia foundation's terms of use", we will need a generic version.
@gonyeahialam The text is inconsistent with regular styling, the light grey is usually reserved for disabled text or help text. can we agree that it will not be grey and instead the standard black?

@ifried The message here is Wikimedia specific "In accordance with the Wikimedia foundation's terms of use", we will need a generic version.

@MHorsey-WMF What terms of use will the generic version be linked to since the one currently linked is Wikimedia's?

@gonyeahialam The text is inconsistent with regular styling, the light grey is usually reserved for disabled text or help text. can we agree that it will not be grey and instead the standard black?

The color I am using is the color for subtle text #54595D/Gray600/Base 20. The disabled color is #72777D/Gray500/Base30. But since this text is for an action and clickable you can go ahead to use the standard black (#202122/Gray700/Base10) so it is not confused as disabled.

@ifried The message here is Wikimedia specific "In accordance with the Wikimedia foundation's terms of use", we will need a generic version.

Engineering/Design meeting
Proposed text: “I agree to handle the participant information collected during event registration with care”

@ifried Please review if this is generic enough for the clickwrap text in the case of non-wikimedia installation. We agreed to remove the last part of the sentence ("In accordance with the Wikimedia foundation's terms of use").

Agreed in Design meeting 18/10/2023 - remove reference to Wikimedia but retain the rest of the message.

Change 966875 had a related patch set uploaded (by Mhorsey; author: jenkins-bot):

[mediawiki/extensions/WikimediaMessages@master] Override agreement to wikimedia terms of use in campaignEvents extension.

https://gerrit.wikimedia.org/r/966875

Change 966875 abandoned by Mhorsey:

[mediawiki/extensions/WikimediaMessages@master] Override agreement to wikimedia terms of use in campaignEvents extension.

Reason:

Strange merge artefacts

https://gerrit.wikimedia.org/r/966875

I approve of the updated AC. Thank you, @MHorsey-WMF!

Change 963278 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Implementation of front end for clickwrap

https://gerrit.wikimedia.org/r/963278

Change 967158 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/WikimediaMessages@master] Override agreement to wikimedia terms of use in campaignEvents extension.

https://gerrit.wikimedia.org/r/967158

Change 967158 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Override agreement to wikimedia terms of use in campaignEvents extension.

https://gerrit.wikimedia.org/r/967158

Given I am an organizer
When I go to Special:EnableEventRegistration
✅ Then the agreement text for viewing PII should be shown
✅ And a checkbox should be shown to accept the agreement

Screenshot 2023-11-06 at 6.15.04 PM.png (158×1 px, 44 KB)

Given I am an organizer
When I go to Special:EditEventRegistration
And I have not accepted the PII agreement
✅ Then the agreement text for viewing PII should be shown
✅ And a checkbox should be shown to accept the agreement

Screenshot 2023-11-06 at 6.28.16 PM.png (1×2 px, 364 KB)

Given I am an organizer
When I go to Special:EditEventRegistration
And I have accepted the PII agreement
✅ Then the agreement text for viewing PII should be shown
✅ And a checkbox should be shown that is disabled.

Screenshot 2023-11-07 at 10.08.10 AM.png (1×2 px, 412 KB)

Given I am an organizer
When I go to Special:EventDetails
And I am viewing the Response Statistics tab
And I have not accepted the PII agreement
✅ Then the agreement text for viewing PII should be shown
✅ And a checkbox should be shown to accept the agreement
✅ And a button to submit the acceptance should be shown.

Screenshot 2023-11-06 at 6.32.26 PM.png (828×1 px, 136 KB)
Screenshot 2023-11-06 at 6.33.10 PM.png (772×1 px, 134 KB)

Given I am an organizer
When I go to Special:EventDetails
And I am viewing the Response Statistics tab
And I have accepted the PII agreement
✅ Then I should see the standard content for the response statistics tab

Screenshot 2023-11-07 at 10.09.20 AM.png (1×1 px, 166 KB)

Given the environment is a wikimedia foundation wiki
✅ the PII agreement text should read: "I agree to handle the participant information collected during event registration with care and in accordance with Wikimedia Foundation's https://foundation.wikimedia.org/wiki/Special:MyLanguage/Policy:Terms_of_Use Terms of use."


Given the environment is not a wikimedia foundation wiki
✅ the PII agreement text should read: "I agree to handle the participant information collected during event registration with care."

Screenshot 2023-11-07 at 12.54.03 PM.png (1×1 px, 222 KB)

❌ All other text should be as per the below designs.

  • There are some discrepancies between the rest of the text in the comp and what is in the build. I have noted them below, but I am wondering if this should be in another ticket or if these have changed since this ticket was written? @MHorsey-WMF Note that the line To view the aggregated responses of participants you must accept the following: is currently in the build in two different places, and it should be there only once.
compbuild
Screenshot 2023-07-27 at 12.33.24.png (1×1 px, 212 KB)
Screenshot_2023-11-07_at_1.00.06_PM.png (1×1 px, 263 KB)

@vaughnwalters @MHorsey-WMF

  1. For the copy, go with the copy in the build.
  2. "To view the aggregated responses of participants you must accept the following:" should appear only once at the bottom.
  3. The "To view the aggregated responses..." is too close to the Other questions section and too far apart from the clickwrap checkbox. It should spaced further from the Other questions and closer to the check box as shown in the design:

Screenshot 2023-11-08 at 09.54.56.png (1×1 px, 330 KB)

Change 974511 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Change spacing and remove duplicated copy

https://gerrit.wikimedia.org/r/974511

Change 977675 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix duplicate clickwrap message in the registration form

https://gerrit.wikimedia.org/r/977675

We will delay making a decision on how to handle the spacing issue in this ticket, and spacing changes will not be done in the scope of this ticket. This is because we plan to probably change how we display the clickwrap agreement in general very soon, since we want to allow organizers to choose which participant questions are included in their registration form.

Change 977675 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix duplicate clickwrap message in the registration form

https://gerrit.wikimedia.org/r/977675

Moving this to QA. If there's anything that needs to be fixed, I think it should be addressed in another task, especially considering the age of this task and the fact that we're going to change this form section soon for T322209.

Because we are using the copy in the build per (T340115#9315472) and spacing changes will not be done in this ticket (per T340115#9371729) and the duplicated line (To view the aggregated responses of participants you must accept the following:) is now correctly displayed only once, I am moving this ticket to design sign off.

Screenshot 2024-01-22 at 4.18.36 PM.png (1×1 px, 261 KB)

Change 974511 abandoned by Mhorsey:

[mediawiki/extensions/CampaignEvents@master] Change spacing and remove duplicated copy

Reason:

Done in a different patch

https://gerrit.wikimedia.org/r/974511