Directory

<img draggable="false" role="img" class="emoji" alt="⚓" src="https://s.w.org/images/core/emoji/15.0.3/svg/2693.svg"> T335273 Echo notification count disappears on load in mobile skin
Page MenuHomePhabricator

Echo notification count disappears on load in mobile skin
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Have some notifications that you've seen, but not read; i.e. on desktop, you have gray numbers in the alert and/or messages icons: F36961642
  • Navigate to a mobile site (Minerva skin)

What happens?:

  • On page load, the number of notifications total is briefly visible, but then it disappears within a second, and is not replaced with the normal "red circle" showing a number of notifications: F36961644

What should have happened instead?:
The total number of unread notifications should be visible, either in a red or gray circle.

The total number of notifications does not appear at all.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Confirmed (ptwiki wmf.12 and betalabs) - seen (gray) echo notifications on mobile will appear only momentarily, see the gif below

flashing_echo.gif (812×420 px, 184 KB)

I think the issue here is the module ext.echo.styles.badge which shouldn't be loaded on Minerva skin. It's overriding the existing styles inside Minerva.

NOTE: Minerva has never shown "seen" notifications. Only unread.

Change 929807 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Fixes: Echo notification count disappears on load in mobile skin

https://gerrit.wikimedia.org/r/929807

@Jdlrobson's patch has an opposite fix to what is described in the description (the number is not present instead of being present in a circle). It's currently unclear within the Foundation whether the circle is a good design practice in a first place, and whether it makes sense to fix the notifications bar on mobile to use it more. After talking to Jon, I've merged the patch to make the behavior self-consistent at least; if we decide which one is correct later, we can do that in a follow-up.

Urbanecm_WMF triaged this task as Low priority.
Urbanecm_WMF updated the task description. (Show Details)
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 929807 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fixes: Echo notification count disappears on load in mobile skin

https://gerrit.wikimedia.org/r/929807

@Jdlrobson's patch has an opposite fix to what is described in the description (the number is not present instead of being present in a circle

The mobile site has only ever shown unread and unseen notification count. When the notifications are seen it becomes a bell icon. It was a recent regression that the number started showing up.

On the longer term it would be nice to rethink whether we need 2 icons and if so to reconsider the Minerva treatment so it is more consistent with desktop.

It might be worth resolving this and centering the discussion in one place e.g. https://phabricator.wikimedia.org/T231180 so we don't have conversations in multiple places.

Change 943602 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/Echo@master] Revert "Fixes: Echo notification count disappears on load in mobile skin"

https://gerrit.wikimedia.org/r/943602

Change 943602 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Revert "Fixes: Echo notification count disappears on load in mobile skin"

https://gerrit.wikimedia.org/r/943602

Change 943605 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/Echo@wmf/1.41.0-wmf.20] Revert "Fixes: Echo notification count disappears on load in mobile skin"

https://gerrit.wikimedia.org/r/943605

Change 943605 merged by jenkins-bot:

[mediawiki/extensions/Echo@wmf/1.41.0-wmf.20] Revert "Fixes: Echo notification count disappears on load in mobile skin"

https://gerrit.wikimedia.org/r/943605

Mentioned in SAL (#wikimedia-operations) [2023-08-01T09:35:49Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:943605|Revert "Fixes: Echo notification count disappears on load in mobile skin" (T335273 T343192)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-01T09:37:26Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:943605|Revert "Fixes: Echo notification count disappears on load in mobile skin" (T335273 T343192)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-01T09:47:24Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:943605|Revert "Fixes: Echo notification count disappears on load in mobile skin" (T335273 T343192)]] (duration: 11m 35s)

Patch got reverted because it caused T343192. Moving back from QA. FYI @Jdlrobson.