updated url links for input methods with their various mediawiki docu… #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srish
requested changes
Dec 20, 2024
There was a problem hiding this comment.
@obamwonyi Thanks a lot for this PR! There is one minor fix needed in a URL. Once that is addressed, I will go ahead and merge.
rules/vai/vai-transliteration.js
Outdated
| @@ -6,7 +6,7 @@ | |||
| name: 'Vai Transliteration', | |||
| description: 'Vai Transliteration, based on the SIL Keyman layout found at https://github.com/keymanapp/keyboards/tree/master/release/sil/sil_vai/source, with extensions', | |||
| date: '2019-05-08', | |||
| URL: 'https://github.com/wikimedia/jquery.ime', | |||
| URL: 'https://www.mediawiki.org/wiki/Help:Extension:UniversalLanguageSelector/Input_methods/vai-transliterationimedia/jquery.ime', | |||
There was a problem hiding this comment.
URL needs to be fixed here. To be replaced with https://www.mediawiki.org/wiki/Help:Extension:UniversalLanguageSelector/Input_methods/vai-transliteration
There was a problem hiding this comment.
I have implemented the fix.
|
OK , I will fix and make the push later today. |
|
Hi, I have implemented the fix. |
srish
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated each URL value for the necessary input method ( input methods that do not have url or have this repo as their url link for documentation on that particular input method ) with that of their various media wiki documentation.
I also looked up the urls provided by some input methods and if they are no longer working (404 error page) I replace them with that of Mediawiki. This is to resolve the issue raised on Phabricator-T381067.