Directory

added font directory path and size to site health by andr3ribeiro · Pull Request #6260 · WordPress/wordpress-develop · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added font directory path and size to site health #6260

Conversation

andr3ribeiro
Copy link

Added the font directory in the array for site health table iteration

Trac ticket: https://core.trac.wordpress.org/ticket/60719

Copy link

Hi @andr3ribeiro! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link

github-actions bot commented Mar 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props andr3ribeiro, audrasjb, peterwilsoncc, ironprogrammer.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ironprogrammer
Copy link

Thanks for the PR, @andr3ribeiro! Perhaps a good addition to this would be to include the fonts dir "is writable" check found on the Filesystem Permissions tab. This work is something we could probably get merged early this cycle.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the uploads directory tests, this should use the basedir value rather than path.

While they are the same on a default WordPress install, plugins may filter the path for individual uploads by adding a sub-directory, for example:

array (
  'path' => '/path/to/wp-content/uploads/fonts/font-family',
  'url' => 'http://example.com/wp-content/uploads/fonts/font-family',
  'subdir' => '/font-family',
  'basedir' => '/path/to/wp-content/uploads/fonts',
  'baseurl' => 'http://example.com/wp-content/uploads/fonts',
  'error' => false,
)

src/wp-admin/includes/class-wp-debug-data.php Outdated Show resolved Hide resolved
src/wp-admin/includes/class-wp-debug-data.php Outdated Show resolved Hide resolved
audrasjb and others added 2 commits June 3, 2024 11:48
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
@audrasjb
Copy link
Contributor

audrasjb commented Jun 3, 2024

I committed the changes suggested by @peterwilsoncc directly to the PR.

@audrasjb
Copy link
Contributor

audrasjb commented Jun 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants